docs: fix README accuracy and sync Chinese translation#38
Conversation
Co-authored-by: cdfmlr <45259230+cdfmlr@users.noreply.github.com>
Co-authored-by: cdfmlr <45259230+cdfmlr@users.noreply.github.com>
Co-authored-by: cdfmlr <45259230+cdfmlr@users.noreply.github.com>
cdfmlr
left a comment
There was a problem hiding this comment.
@copilot generally ok. but the mentioned details should be improved (do also update the corresponding translation
README.md
Outdated
| ### conds-align (Beta) | ||
|
|
||
| The `conds-align` parameter controls whether consecutive If statements are aligned in the flowchart. When `conds-align=True`, consecutive If statements are aligned in the flowchart. | ||
| When `conds_align=True`, consecutive `if` statements are laid out horizontally, which often makes the resulting diagram easier to read. |
There was a problem hiding this comment.
consecutive
ifstatements are laid out horizontally
this is not always true. it depends. they are just aligned, horizontally or vertically.
There was a problem hiding this comment.
Fixed in e0c7f64 — changed to "aligned in the flowchart (horizontally or vertically, depending on the layout)".
README.md
Outdated
|  | ||
|
|
||
| Opening the `output.html` in your browser will let you visualize the diagrams. You can tweak the code and click run to update the diagram. There are also links to download the current visuals as a `.svg` or `.png` image. | ||
| Open `output.html` in your browser to view the interactive diagram. You can edit the flowchart DSL in the text area and click **Run** to refresh the diagram. Download links for `.svg` and `.png` exports are also provided. |
There was a problem hiding this comment.
the interactive diagram
the interactivity is really limited. it's basically a rendered flowchart visualization instead of a "interactive diagram"
There was a problem hiding this comment.
Fixed in e0c7f64 — changed to "visualize the flowchart" to avoid overstating the interactivity.
| ⚠️ The output file specified will overwrite any file that already has that name. | ||
| ⚠️ The specified output file will be overwritten if it already exists. | ||
|
|
||
| 🐍 To use this feature via Python instead of CLI, call `output_html(output_name: str, field_name: str, flowchart: str) -> None`: |
|
|
||
| ```py | ||
| >>> import pyflowchart | ||
| >>> help(pyflowchart.output_html) |
There was a problem hiding this comment.
keep the guide to the detailed help.
There was a problem hiding this comment.
Restored in e0c7f64 — the >>> help(pyflowchart.output_html) guide is back.
Co-authored-by: cdfmlr <45259230+cdfmlr@users.noreply.github.com>
cdfmlr
left a comment
There was a problem hiding this comment.
@copilot
the chinese translation is not updated with the HTML output description and latest Copyright year etc...
i am now kind of doubting the overall work quality since you cannot even performance a simple translation correctly and aligned.
doubly check it yourself!
you'd better take it seriously. your changes will be reviewed by other agents including openai codex and google gemini pro. show them your advantaged intelligence and hard work. do make them have nothing to picky with.
Co-authored-by: cdfmlr <45259230+cdfmlr@users.noreply.github.com>
Fixed in 003a6bd. The Chinese README is now fully in sync with the English:
|
cdfmlr
left a comment
There was a problem hiding this comment.
double check it, everything about the document, is it really ready for public? @copilot
Co-authored-by: cdfmlr <45259230+cdfmlr@users.noreply.github.com>
Done a thorough section-by-section review. Both READMEs are now fully in sync — fixed one remaining gap in 6f1fa94: the Chinese Quick Start was missing the concrete example line (
|
…READMEs Co-authored-by: cdfmlr <45259230+cdfmlr@users.noreply.github.com>
Several inaccuracies and inconsistencies in README.md and README_zh-CN.md, identified through reviewer feedback and a full quality audit.
Corrections
conds_aligndescription: "laid out horizontally" → "aligned (horizontally or vertically, depending on the layout)" — alignment direction is layout-dependent, not fixedoutput_htmlsentence in "Flowchart in Python": removed "(like the screenshot above)" — that screenshot is from flowchart.js.org, notoutput_html; the two look nothing alikeRestored content
>>> help(pyflowchart.output_html)guideChinese README sync
All of the above applied to
README_zh-CN.md, plus:--conds-alignCLI description: removed "水平" (horizontal-only) constraint-fsection: added missing concrete example line (python -m pyflowchart example.py -f MyClass.add)Whitespace cleanup (README.md)
...continuation prompt in the REPL example🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.